pt.javascript.info icon indicating copy to clipboard operation
pt.javascript.info copied to clipboard

Quantifiers +, *, ? and {n}

Open peruibeloko opened this issue 1 year ago • 5 comments

peruibeloko avatar Feb 06 '24 14:02 peruibeloko

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

@jonnathan-ls, could you review it?

nazarepiedady avatar Mar 08 '24 10:03 nazarepiedady

@Peruibeloko, I think you could also look at your own pull request and approve it if you agree with what you did. This would help a lot when we don't have enough people online to look at it.

nazarepiedady avatar Mar 08 '24 10:03 nazarepiedady

@nazarepiedady that would be a conflict of interests, wouldn't it? the idea of reviews is to catch errors

peruibeloko avatar Mar 08 '24 10:03 peruibeloko

@Peruibeloko, yes, but you are also a reviewer even not being a maintainer. I also think that you have a good point.

nazarepiedady avatar Mar 08 '24 12:03 nazarepiedady

/done

peruibeloko avatar Mar 23 '24 21:03 peruibeloko

@Peruibeloko, excellent, now we can go forward. @odsantos, and @jonnathan-ls, could you review it quickly as possible?

We need to merge all current opened pull request to do a good review on the issues and to organise the things to start to add new translations.

nazarepiedady avatar Mar 24 '24 05:03 nazarepiedady

that would be a conflict of interests, wouldn't it? the idea of reviews is to catch errors

I agree with @Peruibeloko in relation to the translator ending up accepting the PR itself, although it is a documentation repository, if we consider the same premise as the code, whoever opened the PR may end up missing errors that they would not end up catching, hence the need to have reviewers for a look beyond the context (this corroborates the project's premise of having 02 reviewers, to avoid possible translation errors and ending up being taken to production when the translation is incorporated into the javascript.info website '

But I also consider @nazarepiedady's observation valid, unfortunately there are few contributors to this project and we need to release the translation. As it is a documentation repository and not a code repository, perhaps we can be a little more flexible, but if we are going to follow a path like this, I think it is worth creating a separate issue first to evaluate the opinion of other maintainers, at the same time time to ensure that we do not violate the premise adopted by the project owner (repository in English).

jonnathan-ls avatar Mar 30 '24 23:03 jonnathan-ls

@Peruibeloko, @jonnathan-ls, unfortunately this project do not have so many active maintainers so if we depend on the maintainers that are not so active we can not go ahead.

nazarepiedady avatar Mar 31 '24 08:03 nazarepiedady

@nazarepiedady I think your approval is the only one remaining

peruibeloko avatar Apr 02 '24 05:04 peruibeloko

Thank you :sparkling_heart: I updated the Progress Issue #1 :tada: :tada: :tada: