pt.javascript.info icon indicating copy to clipboard operation
pt.javascript.info copied to clipboard

Conditional branching: if, '?'

Open jonnathan-ls opened this issue 3 years ago • 2 comments

Conditional branching: if, '?'

📝 Goal

Article translation

☑ What was done?

  • [x] Translation of the article
  • [x] Translation of the exercises
  • [x] Translation of the SVG image

jonnathan-ls avatar Jun 29 '22 03:06 jonnathan-ls

🚧 work in progress

jonnathan-ls avatar Jun 29 '22 03:06 jonnathan-ls

✅ Ready for review

jonnathan-ls avatar Jul 07 '22 04:07 jonnathan-ls

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

Hi @jonnathan-ls ,

I updated to the English version. As part of the pending tasks could you also resolve the conflicts?

Thanks, Osvaldo.

odsantos avatar Dec 16 '22 20:12 odsantos

Hi @jonnathan-ls ,

I updated to the English version. As part of the pending tasks could you also resolve the conflicts?

Thanks, Osvaldo.

@odsantos conflitos resolvidos.

jonnathan-ls avatar Mar 26 '23 23:03 jonnathan-ls

Hi, Please fell free to tell where you disagree. Thanks, Osvaldo.

@odsantos Correções realizadas.

Apenas algumas sugestões relacionadas a preposição "de", pois entendo que fica um pouco estranho para o leitor.

  • https://github.com/javascript-tutorial/pt.javascript.info/pull/246#discussion_r1148672070
  • https://github.com/javascript-tutorial/pt.javascript.info/pull/246#discussion_r1148666022
  • https://github.com/javascript-tutorial/pt.javascript.info/pull/246#discussion_r1148669533

jonnathan-ls avatar Mar 26 '23 23:03 jonnathan-ls

/done

jonnathan-ls avatar Apr 02 '23 20:04 jonnathan-ls

@jonnathan-ls have you time to update this translation and correct its conflicts?

nazarepiedady avatar Dec 15 '23 02:12 nazarepiedady

@jonnathan-ls have you time to update this translation and correct its conflicts?

Sure, I'll do it on the weekend

jonnathan-ls avatar Dec 15 '23 02:12 jonnathan-ls

@jonnathan-ls I also recommend looking at all your pull requests to see what more needs to be done to let the pull request fine be applied.

nazarepiedady avatar Dec 15 '23 02:12 nazarepiedady

Conflicts resolved @nazarepiedady

@odsantos awaiting analysis of the corrections I made according to your review

jonnathan-ls avatar Dec 16 '23 22:12 jonnathan-ls

@jonnathan-ls Are all reviews requested by @odsantos resolved?

nazarepiedady avatar Dec 23 '23 02:12 nazarepiedady

Are all reviews requested by @odsantos resolved?

Yes, i am waiting his to review again

jonnathan-ls avatar Dec 23 '23 20:12 jonnathan-ls

/done

jonnathan-ls avatar Dec 23 '23 20:12 jonnathan-ls

Thank you :sparkling_heart: I updated the Progress Issue #1 :tada: :tada: :tada: