pt.javascript.info icon indicating copy to clipboard operation
pt.javascript.info copied to clipboard

Data types

Open jonnathan-ls opened this issue 3 years ago • 5 comments

Data types

📝 Goal

Article update

☑ What was done?

  • Pending text translation

jonnathan-ls avatar Jun 16 '22 01:06 jonnathan-ls

Error: the article already translated in the Progress Issue #1 :interrobang:

Error: the article already translated in the Progress Issue #1 ⁉️ https://github.com/javascript-tutorial/pt.javascript.info/pull/243#issuecomment-1157137217 javascript-translate-bot

There is still text that has not been translated.

jonnathan-ls avatar Jun 16 '22 01:06 jonnathan-ls

Error: the article already translated in the Progress Issue #1 interrobang #243 (comment) javascript-translate-bot

There is still text that has not been translated.

Hi,

Will you translate the missing parts, including solution and task? It would be helpful to review that as lesson, the whole translated article as well as the rest.

Trying to know your plan regarding to this lesson.

Thanks, Osvaldo.

odsantos avatar Dec 09 '22 22:12 odsantos

Olá @renatocfrancisco,

Obrigado pela observação, não tinha percebido ❤️

Olá @odsantos,

Will you translate the missing parts, including solution and task? It would be helpful to review that as lesson, the whole translated article as well as the rest.

O PR contempla toda tradução do artigo, com exceção da linha 73 como citado pelo Renato Adicionei um novo commit com o ajuste.

Por desencargo, também atualizei com a master do repositório original.

Poderia adicionar sua revisão a este PR?

jonnathan-ls avatar Aug 06 '23 20:08 jonnathan-ls

Hi @jonnathan-ls , sim. Logo que possivel. Obrigado.

odsantos avatar Aug 08 '23 21:08 odsantos

@Peruibeloko, @jonnathan-ls, what is missing in this pull request?

nazarepiedady avatar Apr 02 '24 05:04 nazarepiedady

... what is missing in this pull request?

The review by two maintainers is missing, I will not contribute with the review, as the PR is precisely my own, there is no point in reviewing it myself

@nazarepiedady Could you add your review?

jonnathan-ls avatar Apr 07 '24 19:04 jonnathan-ls

@jonnathan-ls, now we need one more review. It should take some time because we are running under forces.

nazarepiedady avatar Apr 07 '24 19:04 nazarepiedady

@Peruibeloko, are you available to review this pull request?

nazarepiedady avatar Apr 08 '24 03:04 nazarepiedady

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

@jonnathan-ls, could you consider the reviews did?

nazarepiedady avatar Apr 09 '24 11:04 nazarepiedady

... could you consider the reviews did?

/done @nazarepiedady

I applied the requests noted by @Peruibeloko, see commit https://github.com/javascript-tutorial/pt.javascript.info/pull/243/commits/4a7029ed5e88cb33e49b5c952a71c5f0987f6a8a. And I also added pending content that I noticed when accessing the article from the official English repository bigint-type session, see commit https://github.com/javascript-tutorial/pt.javascript.info/pull/243/commits/7cafcbb3498aa3c5eb433a6104f8d1cd45b84ec2

jonnathan-ls avatar Apr 14 '24 17:04 jonnathan-ls

Error: the article already translated in the Progress Issue #1 :interrobang: