pt.javascript.info icon indicating copy to clipboard operation
pt.javascript.info copied to clipboard

Property flags and descriptors

Open herbertpdl opened this issue 4 years ago • 12 comments

herbertpdl avatar Jul 25 '21 19:07 herbertpdl

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 25 '21 19:07 CLAassistant

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

@odsantos Done!

herbertpdl avatar Jul 28 '21 22:07 herbertpdl

Hi @herbertpdl , the repository was updated and this branch has conflicts, so it also needs to be updated. If you have time to do it, could you please comment in the end here as \done only? It is the way the bot tracks the changes and alters from changes requested to pending review. Thank you.

odsantos avatar Aug 11 '21 22:08 odsantos

/done

herbertpdl avatar Aug 13 '21 12:08 herbertpdl

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

/done

herbertpdl avatar Feb 07 '22 11:02 herbertpdl

Hi @herbertpdl ,

Still working on this one. There is conflict here. If resolved I could try another review.

Thanks, Osvaldo.

odsantos avatar Dec 11 '22 21:12 odsantos

@Peruibeloko, @jonnathan-ls, do you have time to see what is possible to do in relation to this pull request?

nazarepiedady avatar Mar 01 '24 20:03 nazarepiedady

@nazarepiedady his master branch is write protected, but I resolved all the conflicts here: https://github.com/Peruibeloko/pt.javascript.info/tree/herbertpdl/master

peruibeloko avatar Mar 06 '24 03:03 peruibeloko

@Peruibeloko, could you copy his work, review it, and create your own pull request to solve this issue?

nazarepiedady avatar Mar 06 '24 08:03 nazarepiedady

@nazarepiedady will do

peruibeloko avatar Mar 06 '24 14:03 peruibeloko