pt.javascript.info icon indicating copy to clipboard operation
pt.javascript.info copied to clipboard

nullish-coalescing-operator finished

Open ermogenes opened this issue 5 years ago • 8 comments

ermogenes avatar Nov 18 '20 13:11 ermogenes

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 18 '20 13:11 CLAassistant

Hi @ermogenes would you please resolve the conflicts, or inform if you're unavailable for this PR. Thank you.

odsantos avatar Dec 20 '20 20:12 odsantos

@odsantos conflicts resolved.

ermogenes avatar Dec 21 '20 17:12 ermogenes

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

/done

ermogenes avatar Dec 28 '20 11:12 ermogenes

@odsantos Despite what GH shows in compare, I couldn't manage to locate the discrepancy. To me both files has the same line numbers and no extra breaks or spaces.

ermogenes avatar Dec 29 '20 12:12 ermogenes

@ermogenes Thank you.

odsantos avatar Dec 29 '20 12:12 odsantos

Hi @ermogenes,

This PR has one approval. I wonder if it would be possible to keep it with no conflicts until another reviewer might approve it as well. If you are not available to do it, would you please let me know to see if I might be able to do that?

Thank you, Osvaldo.

odsantos avatar May 20 '21 15:05 odsantos

Hi @ermogenes, alright?

Can you equalize the repositories, resolving existing conflicts?

If so, I will perform the analysis for the second review!

jonnathan-ls avatar Oct 14 '22 01:10 jonnathan-ls

@jonnathan-ls done

ermogenes avatar Oct 14 '22 10:10 ermogenes

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

/done

ermogenes avatar Oct 17 '22 10:10 ermogenes

Olá @ermogenes PR aceito, grato pela contribuição ❤️

Se conhecer outras pessoas interessadas em contribuir, sinta-se a vontade para convidá-las 😄

jonnathan-ls avatar Oct 18 '22 22:10 jonnathan-ls