pt.javascript.info
pt.javascript.info copied to clipboard
javascript-tutorial
Methods of RegExp and String
Translation to portuguese done. Followed the english version again.
Source file can be found: https://github.com/javascript-tutorial/en.javascript.info/blob/master/9-regular-expressions/17-regexp-methods/article.md
Hi @fsdude would you please resolve the conflicts, or kindly inform if unavailable to? Thank you.
Hi @fsdude would you please resolve the conflicts, or kindly inform if unavailable to? Thank you.
Hello! Yeah.. lately I've been busy with some work. I don't know if I'll be able to fix this soon, sorry for that =) Thanks by the way
Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:
Hi @kiniggit, @luizclr, @adriavieira314, @Mr-Saxobeat, please since @fsdude might be unavailable I would appreciate it if any of you could review this PR #141 , including my changes. Thank you.
@odsantos aqui também tem o problema da tradução dos
pattern:
@Peruibeloko I'll check and hopefully get back to you soon. Thanks.
@odsantos aqui também tem o problema da tradução dos
pattern:
@Peruibeloko I'm afraid I do not know what you intend to say with this phrase. Please, could you share more details? Thanks.
@odsantos the PRs #147, #141 (this one) and #274 all translated parts of the text that weren't meant to have been translated.
The parts in question are the `pattern:`, `subject:` and `match:` decorators used in the Regex chapters, as they're used by the site builder literally. Changing this might break the builds! My evidence for this is that all of them match the class names used in the HTML output of the site.
@odsantos the PRs #147, #141 (this one) and #274 all translated parts of the text that weren't meant to have been translated.
The parts in question are the
pattern:,subject:andmatch:decorators used in the Regex chapters, as they're used by the site builder literally. Changing this might break the builds! My evidence for this is that all of them match the class names used in the HTML output of the site.
@Peruibeloko I'll include your corrections as soon as possible. Thank you.
@odsantos, @jonnathan-ls, @Peruibeloko, what do you recommend colleagues to be done in this pull request?
@jonnathan-ls, you need to approve and merge if you have time for that, too.
you need to approve and merge if you have time for that, too.
I left my approval, but I don't see any point in merging without the other reviewers who registered observations not reviewing it again yet.
I don't think it's worth closing change requests from other code reviewers
@jonnathan-ls, we will wait most likely for centuries if we wait for others even when we have two approvals. The current pull request is 4 years old. It is too much time.
@jonnathan-ls, let's do this way. You approve, and we will wait at least one week to get one more approval to merge the changes.
@Peruibeloko, could you help us review this 4 years old pull request?
Thank you :sparkling_heart: I updated the Progress Issue #1 :tada: :tada: :tada: