pt.javascript.info icon indicating copy to clipboard operation
pt.javascript.info copied to clipboard

Published 20 hours ago • verified publisher icon javascript-tutorial

JavaScript Animations

Open karlasamantha opened this issue 5 years ago • 21 comments

karlasamantha avatar May 20 '20 03:05 karlasamantha

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 20 '20 03:05 CLAassistant

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

javascript-translate-bot avatar May 22 '20 22:05 javascript-translate-bot

Hi, Karla! Doing fine? Please don't translate or change the source code in the examples. Could you take a look into that? Like, you should keep the ';', spaces and variable names. Cheers!

wnleao avatar May 22 '20 22:05 wnleao

Hi, Karla! Doing fine? Please don't translate or change the source code in the examples. Could you take a look into that? Like, you should keep the ';', spaces and variable names. Cheers!

Hey, yeah. I'm addressing feedback now. My linter changed the code, fixing that :)

karlasamantha avatar May 26 '20 03:05 karlasamantha

/done

karlasamantha avatar May 26 '20 03:05 karlasamantha

Hi @karlasamantha would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you.

odsantos avatar Dec 08 '20 18:12 odsantos

Hi @karlasamantha , please I wonder if you could resolve the conflicts, or kindly inform if unavailable to? Thank you.

odsantos avatar May 16 '21 03:05 odsantos

Hi @karlasamantha , please I wonder if you could resolve the conflicts, or kindly inform if unavailable to? Thank you.

Hi @odsantos , sorry for the delay! I'll try to fix the conflicts today!

karlasamantha avatar May 25 '21 21:05 karlasamantha

/done

karlasamantha avatar May 25 '21 21:05 karlasamantha

/done

karlasamantha avatar May 25 '21 21:05 karlasamantha

Hi @karlasamantha , thank you.

odsantos avatar May 26 '21 18:05 odsantos

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

javascript-translate-bot avatar May 26 '21 18:05 javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

javascript-translate-bot avatar May 27 '21 14:05 javascript-translate-bot

Hello @karlasamantha the English article was updated and this PR now has some conflicts. The changes are small, though. Thank you. Osvaldo.

odsantos avatar Jan 26 '23 18:01 odsantos

/done

karlasamantha avatar Jan 26 '23 21:01 karlasamantha

@odsantos, @jonnathan-ls, @Peruibeloko, what do you recommend colleagues to be done in this pull request?

nazarepiedady avatar Mar 10 '24 05:03 nazarepiedady

@karlasamantha, are you available to update and apply the changes requested?

nazarepiedady avatar Mar 10 '24 05:03 nazarepiedady

@karlasamantha, are you available to update and apply the changes requested?

@nazarepiedady sure, but I don't see any pending changes requested. Am I missing something here?

karlasamantha avatar Mar 11 '24 11:03 karlasamantha

@karlasamantha, I would like to invite you to compare the original English content to the Portuguese content translated by you to see if there are any updates needed or sentences that need to be applied.

I also invite you to check if the reviews did by @odsantos are observed or resolved.

nazarepiedady avatar Mar 11 '24 12:03 nazarepiedady