hi.javascript.info icon indicating copy to clipboard operation
hi.javascript.info copied to clipboard

Published 20 hours ago • verified publisher icon javascript-tutorial

Functions

Open rskhan167 opened this issue 4 years ago • 4 comments

I have translated Functions. Please let me know if there are any changes/modifications needed. Thank you.

rskhan167 avatar Sep 09 '21 19:09 rskhan167

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 09 '21 19:09 CLAassistant

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review :ghost:

javascript-translate-bot avatar Sep 21 '21 00:09 javascript-translate-bot

/done

rskhan167 avatar Sep 21 '21 18:09 rskhan167

Can you have look at all the comments? Also have a re-look at the 1-js/02-first-steps/15-function-basics/article.md file, haven't review all of it. Needs some re-work. Thanks for the contribution. As you are maintaining the project now if you feel something is good enough to be merged feel free to merged even without another review. But make sure you do a proper self-review. Key here to just read the Hindi version and see if everything makes sense. After which you can read the English and Hindi side by side, to check for keywords and other guidelines. Thanks

Thanks for the review. I have made the requested changes also I have gone through 1-js/02-first-steps/15-function-basics/article.md file and made some changes there too. Please let me know if the changes are correct or not.

rskhan167 avatar Sep 21 '21 18:09 rskhan167