en.javascript.info icon indicating copy to clipboard operation
en.javascript.info copied to clipboard

Update article.md to increase readability

Open grantwforsythe opened this issue 2 years ago • 3 comments

To stick with the convention of the rest of the notes, and to increase overall readability, I suggest that we rename the variable r to response which is much more descriptive.

grantwforsythe avatar Feb 17 '23 19:02 grantwforsythe

Looks like a bug. I think we need to add a check for timeout when we check for eviction errors and decide to proceed with deletion based on the check. https://github.com/kubernetes/autoscaler/blob/57f2814267399e0900a70d567a7813089a3cfa5b/cluster-autoscaler/core/scaledown/actuation/group_deletion_scheduler.go#L90-L94

vadasambar avatar Sep 06 '23 18:09 vadasambar

I think adding a test around this scenario is also a good idea.

vadasambar avatar Sep 06 '23 18:09 vadasambar

@leoryu since you are familiar with the code, do you want to fix this :D

vadasambar avatar Sep 06 '23 18:09 vadasambar

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 27 '24 19:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 26 '24 20:02 k8s-triage-robot

/remove-lifecycle rotten

Shubham82 avatar Mar 05 '24 12:03 Shubham82