whenever icon indicating copy to clipboard operation
whenever copied to clipboard

job_list self.respond_to? responds to empty @set_variables

Open brunolarouche opened this issue 2 years ago • 8 comments

Since version 1.4.3 (https://github.com/ruby/irb/compare/v1.4.3...master), irb ruby gem (https://github.com/ruby/irb) is calling directly "respond_to?" method on all included code inside a project. That change makes all code included in a project having that method crashing if implementing it in a way not always returning a true or false, like described in the ruby doc: https://www.rubydoc.info/stdlib/core/Object:respond_to%3F

So, I just wanted to propose that simple change which would prevent that (and maybe) other situations, now always returning a value. I've not used the Ruby '&' in order to be retro-compatible with pre-2.3 ruby versions, in case.

brunolarouche avatar Dec 02 '22 01:12 brunolarouche

ping @benlangfeld

crevete avatar Dec 02 '22 09:12 crevete

I am also affected by the issue @benlangfeld

neualiluj avatar Dec 02 '22 09:12 neualiluj

Hello @trungtran1512, do you have any idea about when this PR will be merged and when a new release will be cut? thanks

crevete avatar Dec 15 '22 20:12 crevete

Hello @crevete, I don't know about this but I tried under local it works fine.

trungtran1512 avatar Dec 19 '22 04:12 trungtran1512

Hello @trungtran1512 who is the maintainer of this project? I guess @benlangfeld? Why he does never respond? Is this project dead? The code base is out-to-date...

crevete avatar Feb 21 '23 20:02 crevete

@crevete https://github.com/javan/whenever/issues/618#issuecomment-1360284334

benlangfeld avatar Feb 21 '23 20:02 benlangfeld

I think it shuold be fixed as

- def self.respond_to?(name, include_private = false)
+ def respond_to?(name, include_private = false)

tompng avatar Apr 05 '23 14:04 tompng

I think it shuold be fixed as

- def self.respond_to?(name, include_private = false)
+ def respond_to?(name, include_private = false)

Makes sense, I've updated the PR, thanks!

brunolarouche avatar Apr 27 '23 14:04 brunolarouche