javalin icon indicating copy to clipboard operation
javalin copied to clipboard

⏫ Upgrade to Micrometer 1.13

Open bogedal opened this issue 1 year ago • 5 comments

Describe the feature Since Micrometer 1.13 introduces a few breaking changes and have deprecated io.micrometer.prometheus.PrometheusMeterRegistry I would like to see javalin-micrometer bumped to this version.

Additional context The breaking changes in 1.13 can be see here Migration Guide

bogedal avatar May 16 '24 04:05 bogedal

@bogedal You want to introduce breaking changes on the current (6x) branch?

tipsy avatar May 16 '24 16:05 tipsy

Edit: nope we cannot

~~I have to say @tipsy I see the value in this, we could have an extra module for the newer micrometer until 7.x then drop the old one?~~

zugazagoitia avatar May 16 '24 19:05 zugazagoitia

Let's add a Javalin 7 tag and let it age like wine until we bump to jetty12

zugazagoitia avatar May 16 '24 19:05 zugazagoitia

Hm.. I accidentally merged this from dependabot because the tests passed 🤔

tipsy avatar Jun 01 '24 08:06 tipsy

Well we should check our tests and potentially revert the changes

zugazagoitia avatar Jun 02 '24 15:06 zugazagoitia

Well, a bit late for that. My bad.

tipsy avatar Aug 09 '24 20:08 tipsy