javalin.github.io icon indicating copy to clipboard operation
javalin.github.io copied to clipboard

Outdated Micrometer plugin documentation

Open varsanyid opened this issue 1 year ago • 1 comments

Hi,

The getting started docs about the Micrometer plugin indicate that the plugin can be instantiated like this:

MicrometerPlugin micrometerPlugin = MicrometerPlugin.Companion.create(micrometerConfig -> micrometerConfig.registry = registry);

However, the Companion object has no create method as per the latest version of the plugin and can only be created the following way: MicrometerPlugin { it.registry = registry }

varsanyid avatar Jun 25 '24 07:06 varsanyid

Thanks for reporting @varsanyid, would you like to submit a PR to fix this?

tipsy avatar Jun 30 '24 16:06 tipsy

@tipsy sorry about the slow response raised a PR #274 to update the samples

varsanyid avatar Aug 03 '24 08:08 varsanyid

Thank you very much :)

tipsy avatar Aug 03 '24 16:08 tipsy

Merged !

tipsy avatar Aug 03 '24 16:08 tipsy