javalin.github.io icon indicating copy to clipboard operation
javalin.github.io copied to clipboard

Issue with HTTP2 shading

Open Goksi opened this issue 1 year ago • 4 comments

Describe the bug While shading javalin ssl inside of spigot plugin, hpack http2 class is not included inside of ServiceLoaders, resulting ERR_CONNECTION_CLOSED Fixed by adding org.apache.maven.plugins.shade.resource.ServicesResourceTransformer transformer. Docs should be updated accordingly.

Screenshots image

Goksi avatar Mar 23 '23 14:03 Goksi

@tipsy assign me and I'll work on it over the weekend (can't assign myself)

zugazagoitia avatar Mar 23 '23 14:03 zugazagoitia

The docker tutorial #177 should also be reviewed.

javalin/javalin#1840 is relevant here.

zugazagoitia avatar Mar 23 '23 15:03 zugazagoitia

Done, thanks !

tipsy avatar Mar 23 '23 16:03 tipsy

Pretty long weekend @zugazagoitia !

tipsy avatar Nov 09 '23 06:11 tipsy