obsidian-leaflet icon indicating copy to clipboard operation
obsidian-leaflet copied to clipboard

🧩 Update font awesome dependency's version

Open MrCrackerplays opened this issue 1 year ago • 1 comments

Scope

I believe the scope would be limited to bumping the versions in package.json. Checking the versions listed in the package.json to the version list implies it hasn't been bumped in about 4 years. The main reason I'm asking is because there are a number of free icons listed on the font awesome website that don't show up within the marker icon search. (e.g. house only showing roughly 4 house icons compared to 19 on the website)

Discovery

Presumably only the package.json, I am not aware of there being any breaking changes within the dependencies that would affect code.

Validate

These are the dependencies I've been referring to

        "@fortawesome/fontawesome-svg-core": "^1.2.35",
        "@fortawesome/free-regular-svg-icons": "^5.15.2",
        "@fortawesome/free-solid-svg-icons": "^5.15.1",

which I believe, but not tested, would have to be updated to these

        "@fortawesome/fontawesome-svg-core": "^6.5.2",
        "@fortawesome/free-regular-svg-icons": "^6.5.2",
        "@fortawesome/free-solid-svg-icons": "^6.5.2",

MrCrackerplays avatar May 31 '24 03:05 MrCrackerplays

yeah, this would be great to have more icons to choose from

Iwuaa avatar Jun 08 '24 19:06 Iwuaa