openjdk-jfx
openjdk-jfx copied to clipboard
javafxports
WIP: remove the isRelative check
Before I write JUnit-Tests I'd like to know if this patch has a chance to be merged
@aghaisas can you take a look at this and give your opinion?
One thing to note is that CSS is one of those very fragile areas where seemingly safe changes will cause regressions we don't catch for months (which speaks both to the complexity and to the lack of sufficient tests), so we need to consider such changes carefully.
The change proposed by @tomsontom looks safe, but, we need to be careful in not breaking something that was fixed in JDK-8124475.
A quick look at the history of this file shows this check was added during - https://bugs.openjdk.java.net/browse/JDK-8124475. There were other changes done in same function & this isRelative check was added.
@tomsontom A good indicator would be both - your test program & the test code in JDK-8124475 continues to pass with your proposed fix.
Ok thanks for the feedback - I'll give those a try and work on a JUnit-Test to ensure no regression. Can we ping David Grieve on that maybe I can recap why he added the isRelative-check.
As announced in this message, the official jfx repository is moving from hg.openjdk.java.net/openjfx/jfx-dev/rt to github.com/openjdk/jfx.
This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed.
Once you have done this, it would be helpful to add a comment with a pointer to the new PR.
NOTE: This will also need a bug ID with a test case before it can be considered.
The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this.