openjdk-jfx icon indicating copy to clipboard operation
openjdk-jfx copied to clipboard

WIP: Additional stylable properties support for ImageView

Open aalmiray opened this issue 6 years ago • 8 comments

Relates to #29. Intended as a the start of discussion as not all properties (viewport, x, y still missing) have been added as stylable.

aalmiray avatar Mar 20 '18 13:03 aalmiray

@andres can you target this PR to develop branch (instead of master)? That way, appveyor might pass. Also, can you comment on the suggestions from @svenreimers

johanvos avatar Mar 27 '18 11:03 johanvos

Yes, I’ll rebase the PR with develop and apply the suggestion by @svenreimers. Give me 1 day and it’ll be done :smile:

aalmiray avatar Mar 27 '18 14:03 aalmiray

Will we need an update on the css reference document as well?

svenreimers avatar Mar 27 '18 22:03 svenreimers

@svenreimers yes, absolutely.

aalmiray avatar Mar 28 '18 06:03 aalmiray

Is this PR waiting for an update on the css reference document?

abhinayagarwal avatar Aug 22 '18 11:08 abhinayagarwal

No, this issue never got to the point where it is ready for code review. There are API design issues that would need to be hammered out first, such as whether we should add more styleable properties for nodes such as ImageView; if so, which attributes; how it interacts with layout.

kevinrushforth avatar Aug 23 '18 23:08 kevinrushforth

@kevinrushforth should the discussion be moved to the mailing list?

aalmiray avatar Aug 25 '18 18:08 aalmiray

As announced in this message, the official jfx repository is moving from hg.openjdk.java.net/openjfx/jfx-dev/rt to github.com/openjdk/jfx.

This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed.

Once you have done this, it would be helpful to add a comment with a pointer to the new PR.

NOTE: since this is a feature / enhancement request it needs to be discussed on the openjfx-dev mailing list if you want it to be considered.


The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this.

kevinrushforth avatar Oct 01 '19 00:10 kevinrushforth