jersey icon indicating copy to clipboard operation
jersey copied to clipboard

Published 20 hours ago • verified publisher icon javaee

JERSEY-3179 Project Reactor Client Reactive Implementation

Open adamzr opened this issue 8 years ago • 8 comments

Jersey's reactive client has implementations for Guava and RxJava. This is an implementation using Project Reactor. The interface it exposes is a Reactive Streams Publisher. This should make it easy to migrate to Java 9 streams in the future.

adamzr avatar Dec 20 '16 03:12 adamzr

Hello Adam,

thanks for your contribution.

In order for us to be able to merge your pull request, you'll need to sign Oracle Contributor Agreement - http://www.oracle.com/technetwork/community/oca-486395.html (instructions are also on that page).

Please note that acceptance of this pull request might be delayed little bit, since it conflicts with JAX-RS 2.1 initiative.

Best regards, Pavel

pavelbucek avatar Dec 20 '16 08:12 pavelbucek

OK, I'll sign the agreement.

Which version of Jersey should I make this depend on?

You say this may get delayed a bit. Any idea on timelines?

Thanks!

adamzr avatar Dec 20 '16 20:12 adamzr

the main issue is that https://github.com/jersey/jersey/blob/master/ext/rx/rx-client/src/main/java/org/glassfish/jersey/client/rx/RxInvocationBuilder.java#L73 is not compatible with https://github.com/jax-rs/api/blob/master/jaxrs-api/src/main/java/javax/ws/rs/client/Invocation.java#L298

we plan to start implementing this "soon" and accepting this will be done after that effort is done.

pavelbucek avatar Dec 21 '16 09:12 pavelbucek

I still don't see your name on the OCA list.

Also, the related work is done - can you please rebase your work (and ideally redo it agains 2.x branch)?

Thanks and regards, Pavel

pavelbucek avatar Feb 02 '17 18:02 pavelbucek

@pavelbucek I sent my email to Oracle for inclusion on the OCA list quite a while ago, but I still have not heard back.

Do you want me to submit my changes as a PR to the 2.x branch as opposed to master?

adamzr avatar Feb 02 '17 21:02 adamzr

@adamzr yes please. That's what I indicated in my last message, sorry if it was not understandable enough.

Make sure that you are using latest bits - you'll notice that 2.x branch implements jax-rs 2.1-m04, which already includes support for rx, so your change will need to be adapted to that.

I don't have any influence on OCA approvals and yours still haven't been approved - I can't do much until that happens.

pavelbucek avatar Feb 15 '17 12:02 pavelbucek

I got OCA approval!

adamzr avatar Feb 16 '17 20:02 adamzr

Hi, has this PR been abandoned ?

tareksha avatar Mar 04 '18 19:03 tareksha