dockerfiles icon indicating copy to clipboard operation
dockerfiles copied to clipboard

get REPO from ARCHIVE_URL in Dockerfile

Open MaxPeal opened this issue 3 years ago • 6 comments

MaxPeal avatar Apr 06 '22 19:04 MaxPeal

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Apr 06 '22 21:04 sonarqubecloud[bot]

This PR does not generate the same output as the existing array. Not all upstream repos are built off of a version tag, some are built using HEAD (esp. if the upstream repo is not good about creating regular version tags).

  • ansible has non-standard versioning and requires alternate handling
  • Not all Dockerfiles have ARCHIVE_URL
  • Some Dockerfiles have GIT_URL
  • Not all Dockerfiles are at app/Dockerfile. See nginx-quic directory for example

jauderho avatar Apr 07 '22 05:04 jauderho

Thank you for your feedback, i can rework the RP to resolve the problems, if technical are all problems resolve, are will you accept a RP like this or is this not the way / direction do you want do go?

MaxPeal avatar Apr 07 '22 12:04 MaxPeal

I'm open to considering this as long as it remains easy to reason about.

It may be easier just to extract the REPO array to a separate file to be updated.

jauderho avatar Apr 07 '22 14:04 jauderho

as of nginx-quic its missing in the ACTION array https://github.com/jauderho/dockerfiles/blob/d19f8af4dfb0b7583e6721ef63ba87f7cc412871/scripts/rebuildAllGo.sh#L34-L38 do you want that i it exclude in the build of the ACTION array / file?

MaxPeal avatar Apr 07 '22 15:04 MaxPeal

as of nginx-quic its missing in the ACTION array

https://github.com/jauderho/dockerfiles/blob/d19f8af4dfb0b7583e6721ef63ba87f7cc412871/scripts/rebuildAllGo.sh#L34-L38

do you want that i it exclude in the build of the ACTION array / file?

This is for a different script rebuildAllGo.sh which is intended only for Go binaries only.

jauderho avatar Apr 07 '22 17:04 jauderho