hakyll icon indicating copy to clipboard operation
hakyll copied to clipboard

Fail check on non success status code

Open clample opened this issue 8 years ago • 2 comments

Currently, external links resulting in a 404 error or other non success status codes will still pass the check.

With these changes, the user is now alerted about non success status codes from external links.

clample avatar Jan 04 '17 19:01 clample

I'm not sure if an error makes sense for all non 2** response codes. It seems like we might get non 2** response codes for pages that are still accessible from the browser. For example, https://medium.freecodecamp.com/yes-im-56-and-learning-to-code-f33abea6fd4c#.zhqs1isvb gave a 409 error when running the check tool but I was able to access this from the browser.

On the other hand, it might be better to over-report issues when looking for broken links than to let possible issues go unnoticed.

clample avatar Jan 10 '17 01:01 clample

This looks good but I think that 3xx status codes should also be valid, external URLs should be free to be moved around.

jaspervdj avatar Jan 20 '17 13:01 jaspervdj