cabal-dependency-licenses icon indicating copy to clipboard operation
cabal-dependency-licenses copied to clipboard

Include dependency copyright notices in output when available

Open jtdaugherty opened this issue 7 years ago • 6 comments

This change makes it possible to use this tool for binary distributions of Haskell programs where copyright notices of the dependencies need to be collected and included. Since this tool did all the hard work, adding the copyright information was easy.

Thanks!

jtdaugherty avatar Mar 18 '17 22:03 jtdaugherty

This looks good, but there's still a conflict -- would you mind merging in master?

jaspervdj avatar Sep 15 '17 06:09 jaspervdj

There are enough changes in master that are at odds with this pull request that I'm not sure how to proceed. For example, upstream added support for specifying the dist directory as an argument, but this PR provides specific strategies in the case of dist and dist-newstyle. If the directory is specified as an argument, there isn't a safe way to choose a search strategy because we don't know what kind of dist directory it is. (And I don't think looking at the directory name is adequate.)

One approach would be to also let the user specify a dist directory type (normal or newstyle) and default to normal, then use that to choose the search strategy.

Thoughts?

jtdaugherty avatar Sep 15 '17 17:09 jtdaugherty

Yeah, it seems like we would need to add a command-line argument.

I wouldn't mind defaulting to new for specific directory names, as long as the behaviour can be overridden using the command-line argument. That way it "does the right thing" in 90% of cases?

jaspervdj avatar Sep 15 '17 17:09 jaspervdj

I don't think I'll have time to resolve the conflicts with master in the near future. My original pull request was filed many months ago, and it would have been helpful to have it merged then, but since the upstream repository moved on in the mean time, I don't feel motivated to deal with the conflicts myself since as far as I'm concerned the changes I made merged cleanly with this package at the time they were written. :)

Still, I'm glad this package continues to evolve, and I'd be happy with closing this PR if the software were still modified to work with new-build-style dist-newstyle directories, since that is an important feature that I need on many projects where I work.

jtdaugherty avatar Oct 02 '17 00:10 jtdaugherty

@kquick @jtdaugherty Please let me know if either of you is interested in taking over this package, I am not using it right now and don't really have time to maintain it well.

jaspervdj avatar Mar 13 '19 15:03 jaspervdj

@jaspervdj Thanks for the offer, but I don't think either @jtdaugherty or myself have time to maintain it in a general fashion either. It's definitely a useful tool for our specific use case (thank you!) but we don't have bandwidth right now to provide general support, just updates for what is needed for our purposes.

Also please note that because we have been maintaining our own fork I did make a few corresponding changes in the cabal file to refer to our version. These are not intended to be interpreted in any negative manner but instead to prevent anyone that is having problems with our version from pestering you about those problems. Please do let me know if you have any concerns about these changes.

Thanks again for the tool and the ownership offer. Should the situation change we will be sure to reach out to you. In the meantime, you are welcome to direct people to try our version if yours does not meet their needs, but at the moment we are focusing our support efforts for this tool primarily on our project needs so we are similarly unlikely to entertain general maintenance requests.

kquick avatar Mar 13 '19 17:03 kquick