node-vcard icon indicating copy to clipboard operation
node-vcard copied to clipboard

Syncronous API

Open andrey-tsaplin opened this issue 8 years ago • 3 comments

Your library implementation does not use any asynchronous APIs. It will be cool if users will be able to use your library without any callbacks too, with no effect to performance.

andrey-tsaplin avatar Jul 28 '16 10:07 andrey-tsaplin

Also your vCard Instance does not holds any data, so creating instance of vCard is absolutely unnecessary.

andrey-tsaplin avatar Jul 28 '16 10:07 andrey-tsaplin

Hi! Sorry for completely missing your awesome work. Would it be possible to rebase your commit?

jasperla avatar Sep 22 '16 20:09 jasperla

Please don't give the method the same name as the object. It should be:

VCard.Parse();

VCard can be a class with a static method named "Parse". In fact, the logic to read from file should be removed in my opinion. The logic to read from file is the responsibility of the user and not of this module.

ultimate-tester avatar Dec 11 '17 13:12 ultimate-tester