jasp-issues icon indicating copy to clipboard operation
jasp-issues copied to clipboard

[Bug]: procces

Open meirsendik opened this issue 11 months ago • 7 comments

JASP Version

0.18.3

Commit ID

No response

JASP Module

Process

What analysis are you seeing the problem on?

model 4

What OS are you seeing the problem on?

Windows 10

Bug Description

Hi,

I tried to do proccess model 4 in jasp, but I got this message:

what is thr problem?

image PIC

Expected Behaviour

Hi,

I tried to do proccess model 4 in jasp, but I got this message:

what is thr problem?

Steps to Reproduce

NO

Log (if any)

No response

Final Checklist

  • [X] I have included a screenshot showcasing the issue, if possible.
  • [ ] I have included a JASP file (zipped) or data file that causes the crash/bug, if applicable.
  • [ ] I have accurately described the bug, and steps to reproduce it.

meirsendik avatar Mar 13 '24 10:03 meirsendik

MENAHALIM2.zip

meirsendik avatar Mar 13 '24 11:03 meirsendik

Rename the variables to something longer. I renamed s to some and ss to ssome and it worked. JASP has trouble in some situations with very short var names... sorrry.

tomtomme avatar Mar 13 '24 12:03 tomtomme

Same bug with flexplot here: https://github.com/jasp-stats/jasp-issues/issues/2188

@kylelang Can this be fixed?

tomtomme avatar Mar 13 '24 12:03 tomtomme

Same bug with flexplot here: #2188

@kylelang Can this be fixed?

I'll see what I can do.

Interestingly, I can reproduce the error on Linux using both the flatpak and source-built versions of JASP, but I don't see the error when running the same analysis through R using jaspTools::runAnalysis(). Maybe the short variable names break something when jasp-desktop processes the data for the R modules?

kylelang avatar Mar 13 '24 12:03 kylelang

It warked! thanks!!

meirsendik avatar Mar 13 '24 13:03 meirsendik

@kylelang @maltelueken I investigated. This one is specifically about a variable named "ss" - maybe "ss" is used in the code of the process for something else? I can name a variable "ww" for example and everything is fine. And I do not even need to include the variable "ss" into the analysis - it just needs to be within the data set and the error appears. Also: This is isolated to process using model numbers. If I use process "input type for model 1 => variables" instead of "model number", everything is fine even using a variable called "ss".

@meirsendik So this is a very weird edge case. Other modules are not affected. So if it is hard to fix somehow, would it be fine for you, if we close this one?

file to replicate the error new.jasp.zip

build info I tested with:

-------- Application Info -------- JASP Version: JASP 0.19 Build Branch: HEAD Build Date: Apr 2 2024 21:25:20 (Netherlands) Last Commit: c8c4acf1dcb12480b97fe7e07583b903366768df

-------- Basic Info -------- Operating System: KDE Flatpak runtime Product Version: 6.5 Kernel Type: linux Kernel Version: 6.6.19-1-MANJARO Architecture: x86_64 Install Path: /app/bin System Local: de_DE

tomtomme avatar Apr 04 '24 08:04 tomtomme

@tomtomme, as you noted, the issue isn't really linked to short variable names. The problem comes up when a variable name is a substring of one of the internal jaspProcess reserve names (e.g., JaspProcess_ModeratorW_Encoded). So, quite a few plausible variable names would trigger the bug (e.g., "proc", "code", "a", "m", "w", "era", etc.).

This PR should fix the bug. I'd recommend keeping this issue open for now (at least until the PR is processed).

kylelang avatar Apr 04 '24 09:04 kylelang