jasp-issues icon indicating copy to clipboard operation
jasp-issues copied to clipboard

[Bug]: JASPs flathub presence

Open tomtomme opened this issue 1 year ago • 7 comments

last update 30. may 2024 image

Bug Description

  • [ ] change "by University of Amsterdam" to https://jasp-stats.org/community-institutional-members

  • [ ] update old screenshot

  • [ ] include >1 screenshot

  • [ ] blue install button should show possibility to install beta OR somewhere include a link to https://static.jasp-stats.org/Nightlies/

  • [ ] donate button links to https://jasp-stats.org/donate which is missing Github-Patreon, see #2565

  • [ ] include changelog OR link to https://jasp-stats.org/release-notes/

  • [ ] change "Manifest" link to https://jasp-stats.org/community-vision-and-goals OR https://github.com/jasp-stats (current link shows some jsons: https://github.com/flathub/org.jaspstats.JASP)

  • [x] get rid of unverified status

  • [x] doing the things neccesary to get rid of the "potentially unsafe" mark

  • [ ] fix wayland application Icon:

On Wayland setWindowIcon() no longer works. This also means that currently is not possible to set a per-window icon (because the xdg-shell standard doesn't allow it). It is still possible to set the main application icon that will be shown in task managers and window decorations: The name of the application icon will be fetched from the .desktop file of the application. The name of the .desktop file must adhere to the reverse domain standard (e.g. org.kde.app.desktop). Most of the KDE applications are already working fine because KAboutData takes care of all the necessary steps. If for some reason your application is not using KAboutData, you need to manually call QGuiApplication::setDesktopFileName(). From https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon

Steps to Reproduce

see https://flathub.org/apps/org.jaspstats.JASP

tomtomme avatar Dec 06 '23 14:12 tomtomme

@tomtomme it seems I can't keep myself from commenting on Linux issues.

I'm not familiar with flathub, I've daily driven Linux for a while now, but I install packages from the repos or the aur.

Still, from what I could see one of the warnings you get is from relying on a old windowing system which I take it as meaning Xorg/X11.

I looked into the jsons on the flatpak and they do seem to rely on X11. You're using Qt for the GUI JASP should run fine on Wayland.

The matter of the read/write permission might be trickier because the user either grants it or has to learn to place the files in a flatpak isolated directory of sorts. Not sure if and how that works.

But the warning about the windowing system seems like an easy fix.

Joao-O-Santos avatar Feb 14 '24 22:02 Joao-O-Santos

I could make a test build with --socket=fallback-x11. Obviously we need to keep supporting X11 until the end of days

RensDofferhoff avatar Feb 23 '24 07:02 RensDofferhoff

these 'unsafe' info not really important , wayland had enabled for JASP if your desktop available. and we don't have to rush to switch to wayland completely because most distributions have just started switching to it, we need to wait for it to be stable to allow user experience to be a priority.Read and write permissions are also necessary as JASP needs this read/write data from from 'user/home' locations and OFS networks.

yes we can just to add

 "finish-args": [
        "--socket=fallback-x11",

shun2wang avatar Feb 23 '24 07:02 shun2wang

@shun2wang Agreed. https://github.com/flathub/org.jaspstats.JASP/pull/70

RensDofferhoff avatar Feb 23 '24 07:02 RensDofferhoff

It depends on many situations.Qt6's support for wayland is also gradual and incomplete, and it even depends on your graphics card (for example, NVIDIA is slow to follow up). Overall, KDE is indeed one step ahead.

shun2wang avatar Feb 23 '24 09:02 shun2wang

Our "unverified" status on flathub just got more serious:

https://www.phoronix.com/news/Linux-Mint-Unverified-Flatpaks

tomtomme avatar Jun 03 '24 14:06 tomtomme

I just managed to verify our flatpak but there are new issues. There are requirements now to submissions. So sit tight please

RensDofferhoff avatar Jul 16 '24 12:07 RensDofferhoff