Jason Williams
Jason Williams
In order for us to keep on track with making sure we're focusing on performance i propose we retire the [current benchmarks](https://boajs.dev/boa/dev/bench/) we have and migrate to the V8 benchmarks...
We have new benchmarks https://boajs.dev/benchmarks
The original description doesn't overflow anymore as there's been some optimzations but this example does still cause the issue: https://gist.github.com/jasonwilliams/9f461a7fac0e7721702d82b05fb1012c
> Ideally, I would want this to comment to the PR and continue to update that PR with newly added benchmarks. I think this would be a much better default....
https://github.com/matchai/criterion-compare-action/blob/master/entrypoint.js#L30-L34 would need to be replaced with https://octokit.github.io/rest.js/#octokit-routes-issues-create-comment `tools` would need to be https://github.com/JasonEtco/actions-toolkit#toolscontextissue I can probably do this on a fork, see if it works
Are you getting this with 1.7.8?
Thanks for confirming
That’s great to hear @arsinclair. Feel free to ping me on here or in discord, it’s mainly just attacking the issues already posted. I don’t have time to maintain this...
@cnf collision is much less likely to happen in SHA 256 than in SHA 1 / MD5 SHA 256 is supported in hardware so i doubt you would see much...
Ok cheers If it makes it easier i can remove the 512, as i just need the 256 for now