anki icon indicating copy to clipboard operation
anki copied to clipboard

Adding embeddable cards in a backward compatible way.

Open vavdoshka opened this issue 2 years ago • 4 comments

Added embeddable cards in a backward-compatible way. Allows limiting the scope of the processing to the content between <!-- BEGIN_ANKI_CARDS --> and <!-- END_ANKI_CARDS --> comments.

I found it helpful to embed the Anki Cards definitions into documents with some knowledge base data. This change is backward compatible and should work with all the existing features from how far I've tested.

vavdoshka avatar Dec 12 '22 20:12 vavdoshka

Hey @vavdoshka thanks for this PR, looks good. I’ll try and take a proper look

jasonwilliams avatar Dec 12 '22 22:12 jasonwilliams

I just updated the logic slightly.

vavdoshka avatar Dec 13 '22 18:12 vavdoshka

Hey @vavdoshka, Implementation looks good, it may be worth adding a test here or here

jasonwilliams avatar Dec 14 '22 21:12 jasonwilliams

Pings @vavdoshka are you still active on this?

jasonwilliams avatar Jan 22 '23 11:01 jasonwilliams