anki icon indicating copy to clipboard operation
anki copied to clipboard

Fix some bugs (Mainly string parsing)

Open duguosheng opened this issue 2 years ago • 9 comments

  1. LaTeX curly brackets do not convert correctly #63
  2. a display error: when user sets the saveStrategy to useDirStructure, the actual deck does not match the displayed deck when executing the Send To Deck command
  3. update docs

duguosheng avatar Jul 03 '22 07:07 duguosheng

md file like this:

## test

$a=\{1,2\}$
$b=\#1$ 
$c=\&1$ 
$d=\_1$
$e=\$1$
$f=\%100$ 

before: image

now: image

duguosheng avatar Jul 03 '22 13:07 duguosheng

now, line feed can be sent correctly to anki, but seems like that anki doesn't support it. image

duguosheng avatar Jul 04 '22 02:07 duguosheng

now, content like this can be sent correctly.

$$
\begin{align}
P ::&= P \\
    &|\ \neg P \\
    &|\ \top \\
    &|\ \bot \\
    &|\ P\backslash /P \\
    &|\ P/\backslash P
\end{align}
$$

before: image

now: image

duguosheng avatar Jul 04 '22 06:07 duguosheng

add some tests for this.

duguosheng avatar Jul 04 '22 15:07 duguosheng

add some tests for this.

Thanks!!

jasonwilliams avatar Jul 04 '22 16:07 jasonwilliams

But these tests don't seem very intuitive, because they can't show the final effect. I posted some screenshots in the comments above:)

duguosheng avatar Jul 04 '22 16:07 duguosheng

But these tests don't seem very intuitive, because they can't show the final effect. I posted some screenshots in the comments above:)

What do you think we should do in this case? Should we keep them and use them as a quick sanity check or have a better way to test this? Its a very "visual" thing so i don't know of a better way to test it is working properly

jasonwilliams avatar Jul 04 '22 17:07 jasonwilliams

I've updated the test of latex conversion, maybe this could be better.

duguosheng avatar Jul 05 '22 02:07 duguosheng

fix: Send to DirName just creates a deck called 'deck/subdeck' #80

duguosheng avatar Jul 18 '22 05:07 duguosheng

LGTM

jasonwilliams avatar Aug 20 '22 18:08 jasonwilliams