Jason Varga

Results 524 comments of Jason Varga

I think this issue is still valid in general, but the path issue @heidkaemper outlined I wouldn't consider an issue. You should run the commands in the docker container. šŸ‘

This doesn't work in loops due to how variables are scoped in Antlers. Yes this would push a value to the array like the tests show, but the use case...

This is intentional but in hindsight kinda dumb. We can't change it now though, as some people might be relying on this behavior. The use case is something like this:...

You can add `config(['app.debug' => true])` to the start of that test and run it again to see a better error.

Thank you for this PR but I don't feel it's the right approach.

I can't recreate this. Can you provide the image?

I don't think it should 404. Similar question to say if you have a blog listing page, should it 404 if there are no blog posts? I wouldn't think so....

I just want to clarify something here. Let's say you have an `blog` collection and a `tags` taxonomy. You get `/blog/tags` for free if you have a `blog/tags/index.antlers.html`. This PR...

That's what I'm saying. There's already a 404 if you haven't created the view.

I have a feeling I'm going to be the one proved wrong here šŸ˜… but, my point is that since you already get a 404 if the view is missing,...