Jason Varga

Results 404 comments of Jason Varga

Looks like FatalThrowableError is deprecated, and has probably been removed in Symfony 5. That'd be it.

You'll need to elaborate on what you're doing here. Why are you adding Auth::routes()? What else are you doing? When exactly are you getting the error? What did you click...

A workaround for this is to add the following to your User model (probably `app/User.php`) ``` php public function sendPasswordResetNotification($token) { $this->notify(new \Statamic\Notifications\PasswordReset($token)); } ```

Looks like a good addition to me. What more feedback were you looking for at the moment?

I think you're looking good! We haven't added the feature because no one wanted it yet. 🤷

I'm not sure why the tests are failing like that. I pulled the suite down locally, used the same PHP version and composer deps, and it all passes. 🤔

Yeah I'm fine with that. Looks like Orchestra requires 8.5.21 at a minimum, and 8.5.23 fixes a memory leak. Segfault seems like that's probably what it is. https://github.com/sebastianbergmann/phpunit/pull/4799

Do we need the method? I kinda like assuming `handle`, like a middleware. But yeah the `@` would be more inline with other class/method references.