lunarphase-js icon indicating copy to clipboard operation
lunarphase-js copied to clipboard

Add next and previous lunar phase methods

Open danthareja opened this issue 3 years ago • 5 comments

This is super random, but I was looking for some code to find the date for the next full moon and came across your project.

Instead of re-inventing the wheel, I decided to fork your work and thought I'd submit a PR back.

danthareja avatar Jun 26 '21 00:06 danthareja

@danthareja Hi, appreciate this. My solution is always off by 2-hours, which I haven't had a chance to fully debug.

API is great, but I'm not sure this hits the exact hour and minute? Let me scope this out, and revisit why my solution was off.

jasonsturges avatar Jun 26 '21 03:06 jasonsturges

I'm also here for next phase, and next phase date. That's usually the next thing people want to see after the current phase.

sbsmatt avatar Jun 27 '21 23:06 sbsmatt

@jasonsturges thanks for the review.

I did notice some interesting behavior when testing the timings of this latest full moon.

The current calculation is good enough for my very naive use at the moment, but I am curious to hear if the timings can be tightened up a bit.

danthareja avatar Jun 28 '21 02:06 danthareja

@danthareja Sorry, been through an epic saga of buying a home and moving. Sure you've probably incorporated something into your solution - hopefully this helped give you a start. Getting back into the swing of things and will pick this up.

jasonsturges avatar Aug 08 '21 02:08 jasonsturges

Totally understand man, real life should always take priority over free open source side projects.

I am still curious if you do figure out something here but absolutely no stress

danthareja avatar Aug 09 '21 09:08 danthareja