ansible-role-rabbitmq
ansible-role-rabbitmq copied to clipboard
jasonroyle
fixed generating single quote erlang config file
this fixes #4
also please after merging tag a new version and upload to ansible-galaxy.
it is reported here:
https://github.com/picotrading/ansible-rabbitmq/issues/1
thanks
my latest changes i marked this version as 0.1.0 fixed the cluster and some orders of operations.
also removed the code of the role-dependency and added as a dependecy in the role definition. easier to keep it updated.
@jasonroyle, @Raffaello, I was wondering what was the status on this. I am keen on seeing the cluster creation parts improved in this role and it would be great if these improvements could be merged into the main package.
Is there anything in particular that is holding this up?
@aignas I suspended the work on this role at the moment, i might reprise if there are new goals to achieve. Also it should be review with ansible 2.4 that has improvement on the RabbitMQ functions. I think it is a "dead" role this one. If you have tried to use my fork of this role it might worth moving forward from there and create a new ansible galaxy role and so on... just wait some times about a better answer from @jasonroyle
Hi guys, I like to be quite thorough when accepting pull requests and testing it all first but I just haven't got round to doing this just yet, I do still intend to come back to it at some point but my concentration has been elsewhere. If you would like to help out by becoming a collaborator I would be willing to invite you. Let me know 👍
@jasonroyle, I'd like to become a collaborator, so let me know how we can work on it. :)
@jasonroyle me too, I would like to be a collaborator.
@aignas I do not have really too much time now to work on those changes you have requested. I do not neither remember now and i do not have your perspective on those one. It means at this present time it is impossible for me to commit those changes.
I will be back to work on this in the near future probably, not sure when might be a week or a little bit longer. I can try in free time, but those
@aignas I think: The solution it would be merging this one, tag this actual version publish to ansible galaxy, and moving forward from this. so you will work from this point on the changes you requested.
We can do evolutionary, version based role. canot do to many changes in 1 PR.
Hi @aignas, could you please fix the user issue reported here so it would be possible to make it ready to merge this one? I do not have time now.
@jasonroyle Should we consider to make PR against ansible >= 2.4 only? because for rabbitMQ modules there are some improvements with 2.4 especially for TLS
@aignas for the test related: i might can do with a full VM, docker container and rabbitmq managed with systemd doesn't work (it is stuck on systemd start rabbitmq-server) and anyway when reach that level make sense using the rabbitmq docker image not a "clean OS" to provision. Also it would not be a real test scenario, i guess the scope and goal of this Role is to provision a full OS not a container.