shareplum icon indicating copy to clipboard operation
shareplum copied to clipboard

no instructions for new contributors

Open isaacnorman82 opened this issue 5 years ago • 4 comments

Could you please create a readme on process for contributing?

Process for contributing a feature or bug fix? Rules on code quality? I.e. flake8 How to run tests, what tests to add.

isaacnorman82 avatar Apr 15 '20 11:04 isaacnorman82

I've just tried to create a new feature on a branch feature/Folder-folders (new folders property like existing files) but I get a permission error on push. I see other contributors so maybe I'm not allowed to make a branch? I was trying to push changes in a branch and raise a pull request for approval.

isaacnorman82 avatar Apr 15 '20 11:04 isaacnorman82

I'm not all that knowledgeable on how GitHub works. I'll have to do some research myself. The contributions I have currently come from pull requests in GitHub. The last big pull request I did I cloned from someone's git repository and pushed it into mine. Now he doesn't show up as a contributor, but he is in the git log.

You seem pretty knowledgeable on all this stuff. Do you have any suggestions?

jasonrollins avatar Apr 15 '20 23:04 jasonrollins

I think you just need to add me as a collaborator. This will probably tell you how: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/inviting-collaborators-to-a-personal-repository

I can then create branches, make changes, push my changes to the branch, you can then review the changes and then merge the branch in and delete the branch.

isaacnorman82 avatar Apr 16 '20 00:04 isaacnorman82

Ok done. Let me know how it works. I think you should be able to do so with a pull request, but I have no problem adding you.

jasonrollins avatar Apr 16 '20 00:04 jasonrollins