rbplusplus icon indicating copy to clipboard operation
rbplusplus copied to clipboard

modernize gem

Open sebyx07 opened this issue 1 year ago • 5 comments

  • use standard rspec instead of rake test -- there are some failing specs, but most of them pass if rerun the manually(some problem with ordering)
  • add rubocop for lint
  • remove string mokey patch
  • improve readme

node: I added patch.rb for GCCXML and RbGCCXML

I can make another pr for rbgccxml to update it, then we can look into upgrading rice to latest version

I need this gem to build bindings for https://github.com/azerothcore/azerothcore-wotlk, to script wow server in ruby instead of c++

--

we can this upgrade incremental, merge this, you can do some fixes to the failing specs, I can open the pr to castxml ruby, then remove the patch.rb

then do the rice 4.x update

sebyx07 avatar Sep 07 '24 15:09 sebyx07

https://github.com/jasonroelofs/rbgccxml/pull/21

sebyx07 avatar Sep 07 '24 16:09 sebyx07

Similarly to the RbGCCXML changes, looks like this is majority rubocop updates and test file renaming. I will look at getting these two libraries running under GitHub Actions for CI so we can easier hook that into the PR flow.

jasonroelofs avatar Sep 07 '24 21:09 jasonroelofs

Finished in 3 minutes 22.5 seconds (files took 0.26291 seconds to load)
87 examples, 11 failures, 1 pending

Failed examples:

rspec ./spec/nested_spec.rb:12 # Wrapping Classes within classes should properly make nested classes available
rspec ./spec/allocation_strategies_spec.rb:26 # Allocation Strategies can get access to Neither object
rspec ./spec/allocation_strategies_spec.rb:16 # Allocation Strategies properly figures out what allocation to do
rspec ./spec/class_methods_encapsulate_spec.rb:12 # Correct handling of encapsulated methods should handle private/protected/public
rspec ./spec/class_methods_encapsulate_spec.rb:25 # Correct handling of encapsulated methods should handle virtual methods
rspec ./spec/class_methods_encapsulate_spec.rb:32 # Correct handling of encapsulated methods don't wrap methods that use non-public types in their arguments
rspec ./spec/modules_spec.rb:41 # Extension with modules should be able to generate a module definition
rspec ./spec/modules_spec.rb:45 # Extension with modules should wrap up C++ classes under the namespace as requested
rspec ./spec/modules_spec.rb:50 # Extension with modules should wrap up C++ functions in the module
rspec ./spec/modules_spec.rb:55 # Extension with modules should be able to nest modules and related definitions
rspec ./spec/custom_code_spec.rb:37 # Extension with wrapped classes Adder has new custom methods

I've added the FileUtils.rm and and also the gh workflow

sebyx07 avatar Sep 07 '24 21:09 sebyx07

I just run it with rspec

sebyx07 avatar Sep 07 '24 21:09 sebyx07

let's first do rbgccxml, so I can remove that patch.rb

sebyx07 avatar Sep 07 '24 21:09 sebyx07