rbgccxml
rbgccxml copied to clipboard
mornize gem
modenize gem for https://github.com/jasonroelofs/rbplusplus/pull/26
you can run now specs with just rspec, no rake needed
Thanks for putting in the time to do this. Looks like the majority of this is rubocop changes and moving test files / structure around a bit.
Wow, this still is using Travis for CI. We should move this GitHub Actions. I can put together those changes.
Grabbing your PR locally, can we make sure that rake (default invocation) still runs the test suite? I think it just needs a pattern update to the _spec file naming.
you can just run it with rspec or bundle exec rspec
superuser@pop-os:~/workspace/rbgccxml$ rspec
Randomized with seed 47692 ..........................................................................................................error: no such file or directory: '/not/here/clang++' ...
Finished in 6 seconds (files took 0.33641 seconds to load) 109 examples, 0 failures
Randomized with seed 47692
https://github.com/sebyx07/rbgccxml/actions/runs/10754680799/job/29825546163
- got gh actions working
if u can merge it and publish the gem, I can help you with the ci for rbplusplus
There's probably a bit more that needs to be done before anything is published, and I would caution that wrapping something like azerothcore is going to take quite a bit of work, and won't Just Work with rice / rbplusplus. I wouldn't consider rbplusplus finished in any sense of the term, it's just in a state where I stopped working on it. For the time being I would recommend using the master branch of each repo as you get familiar with what your wrapping project needs. I suspect you will be bouncing between rbgccxml, rbplusplus, and rice quite a bit.
Following this, you can also dive into Rice itself directly and start there, getting a feel for what you want to wrap and expose, then add rbplusplus later to help automate the process.
@jasonroelofs - im also thinking about building an automation for C-RICE generation using claude, so to build a prompt and the output will be the file and save it
I also started the project here: https://github.com/sebyx07/rails-on-azerothcore
@jasonroelofs
got some issues
terminate called after throwing an instance of 'std::invalid_argument'
what(): Type is not defined with Rice: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >
/azerothcore/modules/mod-ruby/out/mod_ruby.so: [BUG] Segmentation fault at 0x0000000000000000
ruby 3.3.4 (2024-07-09 revision be1089c8ec) +YJIT [x86_64-linux]
I'll put here some files for context:
https://github.com/sebyx07/rails-on-azerothcore/blob/main/mod-ruby/CMakeLists.txt
https://github.com/sebyx07/rails-on-azerothcore/blob/main/mod-ruby/src/wrap/ac_player.cpp
I would recommend you work through the rice documentation and tutorial to make sure you're familiar with everything the library provides. STL bindings are also a separate section of the library.