Jason Roelofs
Jason Roelofs
Ah, right, that syntax isn't 2.7 compatible. You might need to add extra logic looking for `options[:event]` and throw an ArgumentError if it doesn't exist.
Adding my experiences here, cancellation doesn't seem to work on the hosted version of the app. Locally with the development container version, cancellation works great, but I cannot get it...
An update from my side, turns out I didn't know you needed to re-sync the app when workflow changes are deployed. When I re-sync'd the cancellation event now maps properly...
Oof, 7 years ago was the last commit. No, this library is definitely not active. However the underlying C++ library that this wraps (https://github.com/ruby-rice/rice) is active.
You'd need to update to Rice 4, but it should be a mostly straight forward update, possibly needing an update to any generated `#include`s. You'll also need to grab `[rbgccxml](https://github.com/jasonroelofs/rbgccxml)`...
Similarly to the RbGCCXML changes, looks like this is majority rubocop updates and test file renaming. I will look at getting these two libraries running under GitHub Actions for CI...
Thanks for putting in the time to do this. Looks like the majority of this is rubocop changes and moving test files / structure around a bit. Wow, this still...
Grabbing your PR locally, can we make sure that `rake` (default invocation) still runs the test suite? I think it just needs a pattern update to the `_spec` file naming.
There's probably a bit more that needs to be done before anything is published, and I would caution that wrapping something like azerothcore is going to take quite a bit...
Following this, you can also dive into [Rice](https://ruby-rice.github.io) itself directly and start there, getting a feel for what you want to wrap and expose, then add rbplusplus later to help...