slate-deep-table icon indicating copy to clipboard operation
slate-deep-table copied to clipboard

Published 20 hours ago • verified publisher icon jasonphillips

Support for v0.5

Open phemartin opened this issue 5 years ago • 10 comments

Is there going to be an upgrade to slate v0.5? Really hoping so. Cheers

phemartin avatar Dec 11 '19 18:12 phemartin

@phelipe3 still unclear to me how stable 0.5 is. Seems like Ian is rapidly iterating on it.

mmdonaldson avatar Dec 16 '19 23:12 mmdonaldson

I agree. Seams to be more stable nowadays. Any update?

My current setup really depends on this plugin so I'll be waiting for it. I can also help with the move as well. :)

phemartin avatar Jan 09 '20 23:01 phemartin

@phelipe3 if you have the time, maybe make the PR? How big of a job do you reckon it is?

mmdonaldson avatar Jan 09 '20 23:01 mmdonaldson

I'm looking at this in the coming days as I find time; does anyone happen to know of other mature plugins that have migrated to the new API? It would be helpful to use them as examples when I restructure the code.

jasonphillips avatar Jan 13 '20 02:01 jasonphillips

@mmdonaldson I feel like I'm (currently) not that great of a programmer to issue a PM from scratch, but I definitely can help.

@jasonphillips The best plugin library I'am aware of is slate-plugins-next. (https://slate-plugins-next.netlify.com)

phemartin avatar Jan 13 '20 14:01 phemartin

@phelipe3

Thanks, slate-plugins-next looks very well structured, I can use that as a clean reference.

jasonphillips avatar Jan 15 '20 03:01 jasonphillips

Update: I'm still a bit torn as to how best to proceed with this library, given the discussion here:

https://github.com/ianstormtaylor/slate/issues/3222

slate-plugins-next is a smart approach, but builds its own custom plugins logic on top of slate, and I prefer ideally to have slate's core as my only assumption here. So I could either follow that secondary plugins approach--and wed this library to a strategy that is one step removed from slate, and might break since it's not part of slate's internal assumptions--or turn this library into a set of smaller components that you hook into your slate instance somewhat manually, since the concept of a single "plugin" enclosing many changes (schema, key listeners, etc) is no longer part of slate's design.

jasonphillips avatar Feb 06 '20 19:02 jasonphillips

@jasonphillips what are you leaning towards? 0.5 fixes some long standing formatting bugs (worth upgrading for) and we also depend on slate-deep-table

samlevin avatar Feb 27 '20 22:02 samlevin

FYI we are beginning the upgrade this week

mmdonaldson avatar Sep 29 '20 03:09 mmdonaldson

Is this already supported yet?

rnnyrk avatar Feb 02 '21 09:02 rnnyrk