ember-cli-moment-shim icon indicating copy to clipboard operation
ember-cli-moment-shim copied to clipboard
verified publisher icon jasonmit

fixed moment-with-locales.js path issue

Open AThiyagarajan opened this issue 2 years ago • 3 comments

With the recent versions of moment the path has been updated. This PR fixes the moment-with-locales.js path issue Also updated the moment and moment-timezone package versions

AThiyagarajan avatar Mar 30 '23 07:03 AThiyagarajan

@jasonmit Could you please review this one?

AThiyagarajan avatar Mar 30 '23 08:03 AThiyagarajan

Hi @jasonmit , I understand that you may be busy with your work schedule. Since this is a small fix, is there any chance that this will be merged and released?

AThiyagarajan avatar Apr 06 '23 13:04 AThiyagarajan

@AThiyagarajan I no longer have any way to test changes here and hesitate to merge anything without a way to validate it. The best path forward for users of this addon is to follow the guide at https://github.com/adopted-ember-addons/ember-moment#using-momentjs-in-ember-apps--addons and remove this addon from your build entirely.

jrjohnson avatar Apr 06 '23 15:04 jrjohnson