cordova-wheel-selector-plugin icon indicating copy to clipboard operation
cordova-wheel-selector-plugin copied to clipboard

Text not showing in selection popup/dialog box for API level 29 above

Open hamelgoyal opened this issue 4 years ago • 7 comments
trafficstars

Hi Team,

Been using this plugin for a while. Recently I updated API level of my app to 29 from 28 due to Google's app policy. But suddenly this plugin stops working. Checked for previous releases, It says issued is solved with the release 1.1.6 . But it isn't. I'm stuck here from last few weeks. Due to complex app structure can't afford to use another plugin/option. Can anyone from the team check this on urgent basis.

Thanks, [email protected] 24

hamelgoyal avatar Jul 04 '21 13:07 hamelgoyal

@jasonmamy. Sorry for tagging directly. Can you please check.

hamelgoyal avatar Jul 04 '21 13:07 hamelgoyal

I don't know when I would be able to look at it. Look in the GitHub source java code for API calls that could have created the issue.

On Sun, Jul 4, 2021, 6:35 AM Hamel Goyal @.***> wrote:

@jasonmamy https://github.com/jasonmamy. Sorry for tagging directly. Can you please check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/63#issuecomment-873592248, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPVJRQUNRLFL6Q7JJMREZTTWBPSZANCNFSM47ZGMNSQ .

jasonmamy avatar Jul 04 '21 18:07 jasonmamy

Hi,

Not sure if I have bandwidth to check and solve this. Request you to please find workaround till then. My app release is stuck. A humble request to check this issue.

Thanks,

hamelgoyal avatar Jul 05 '21 05:07 hamelgoyal

Confirmed if you upgrade the Android API level to conform to Google's new policies, it completely breaks this plugin. Currently attempting to debug, has anybody solved this?

Here's the actual error message hit on the setNumberPickerTextColor method: Accessing hidden field Landroid/widget/NumberPicker;->mSelectorWheelPaint:Landroid/graphics/Paint; (greylist-max-p, reflection, denied)

UPDATE: https://developer.android.com/about/versions/10/non-sdk-q Listed on the link provided above - Landroid/widget/NumberPicker;->mSelectorWheelPaint:Landroid/graphics/Paint; # No public alternative. Developers should never access this field directly.

Therefore this plugin will not work anybody currently leveraging Android (since even existing users are required to be on API level 30 by November and this broke at 29) until an update is made. @jasonmamy apologies for the direct tag but just drawing attention for context

kevryan2 avatar Jul 26 '21 17:07 kevryan2

There is a commit targeting API >= 29 https://github.com/jasonmamy/cordova-wheel-selector-plugin/commit/136717222845fbc9c5b37ba729aaf1350dd51e0f

Is it related?

mirko77 avatar Jul 04 '22 16:07 mirko77

It's been a while since I've looked at this plugin, but as Mirko77 mentioned, that commit looks like it could cause the issue that Hamel is mentioning. Hamel, you might try changing the line 222 in the commit and bump up the number 29 to something higher, and see if it fixes the issue? If so we can push out a new release.

On Mon, Jul 4, 2022 at 9:51 AM Mirko77 @.***> wrote:

There is a commit targeting API >= 29 here -> 1367172 https://github.com/jasonmamy/cordova-wheel-selector-plugin/commit/136717222845fbc9c5b37ba729aaf1350dd51e0f

Is it related?

— Reply to this email directly, view it on GitHub https://github.com/jasonmamy/cordova-wheel-selector-plugin/issues/63#issuecomment-1174002106, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPVJRQEPJYD2PSFFY7HR7LVSMI73ANCNFSM47ZGMNSQ . You are receiving this because you were mentioned.Message ID: @.***>

jasonmamy avatar Jul 04 '22 18:07 jasonmamy

I tested the plugin against API 30 on Android 12, 11, 10, and 9: all looks good. How do I reproduce the issue?

gradle

ext {
    minSdkVersion = 21
    compileSdkVersion = 30
    targetSdkVersion = 30
    androidxActivityVersion = '1.2.0'
    androidxAppCompatVersion = '1.2.0'
    androidxCoordinatorLayoutVersion = '1.1.0'
    androidxCoreVersion = '1.3.2'
    androidxFragmentVersion = '1.3.0'
    junitVersion = '4.13.1'
    androidxJunitVersion = '1.1.2'
    androidxEspressoCoreVersion = '3.3.0'
    cordovaAndroidVersion = '7.0.0'
}


wheel

mirko77 avatar Jul 05 '22 08:07 mirko77