react-popover
react-popover copied to clipboard
jasonkuhrt
Exposing animations via props
I ended up addressing my own notes above, combining the override props into a single animationHandlers object that's overridden all-or-nothing, as well as changing the this binding on the handlers to passing the popover after playing more with my usecase.
Thanks for putting this together @stephen! The current hard-coded animation solution is a sore point. I'm interested in using a different solution. I had/have been interested in trying https://github.com/chenglou/react-motion. I might have time to review this PR next week. Thanks again.
Happy to help! The nice thing about this is that you can arbitrarily swap out any animation mechanism, react-motion or otherwise. Our usecase was to pair the handlers with facebook's rebound-js:
@jasonkuhrt any updates in this regard? I'd love to have the animations exposed as props.
@macocha last week was my last at littlebits. Maybe @sch can take this up. If this project moves into a neutral repo I might continue to maintain the project but otherwise it's in littleBits' hands.
Happy to take a look! I agree with @stephen that the best solution would be to provide hooks for animation to occur, regardless of what the underlying animation library is.
Hi @sch - I've merged against master so things should be able to cleanly merge again. For API symmetry, I've kept enterStop so that animation implementors can take advantage of it.
Let me know if I can do anything else to help get this shipped!
@jasonkuhrt Any chance this or #84 can be merged (since you tagged it as high priority)? We have CSS hacks in place right now to override the animation but an API solution would be so much more preferred!
Thank you so much!
