ErsatzTV icon indicating copy to clipboard operation
ErsatzTV copied to clipboard

External subtitle support with `HLS Direct` streaming mode

Open krutburken opened this issue 2 years ago • 5 comments

I know there's currently basic support for embedded subtitles, but sadly the vast majority of mine are external ones. Supporting those too would be a very nice addition.

krutburken avatar May 31 '22 18:05 krutburken

External subtitles are supported using Plex's naming scheme https://support.plex.tv/articles/200471133-adding-local-subtitles-to-your-media/

Some examples are here https://github.com/jasongdove/ErsatzTV/blob/ca5d303ac787aeca00d40971ed1aea866dc51d1a/ErsatzTV.Core.Tests/Metadata/LocalSubtitlesProviderTests.cs#L16-L25

Can you give a specific example where this does not work? Perhaps there is a bug to fix.

jasongdove avatar May 31 '22 19:05 jasongdove

Oh, that's interesting, so far only the embedded ones are getting picked up for me. I'll do some testing and get back to you.

krutburken avatar May 31 '22 19:05 krutburken

Ah, so specifically I'm looking for support for external subtitles when using HLS DIrect, when transcoding they work great.

When using HLS Direct and an external .srt the stream refuses to play, and I get: Forcing 1 ffmpeg thread due to buggy combination of stream seek and realtime output

krutburken avatar May 31 '22 20:05 krutburken

Forcing 1 ffmpeg thread due to buggy combination of stream seek and realtime output

This is an info message (not a warning) just telling you that your thread setting from the ffmpeg profile is being ignored.

external subtitles when using HLS Direct

This would definitely be a new feature. Will track it here.

jasongdove avatar Jun 01 '22 13:06 jasongdove

See https://github.com/jasongdove/ErsatzTV/issues/1138 for discussion on embedded subtitles with HLS Direct. Once embedded subtitles are working, I can then look at external subtitles.

jasongdove avatar Jun 04 '23 18:06 jasongdove