Jason Lee
Jason Lee
@bstansberry All changes should be address 'cept for the import order. Those have been updated, but I'll wait to resolve those until I can confirm I have the right order....
> @jasondlee I'm withdrawing my approval because the tests are failing. @bstansberry You're so picky. :) I've been reworking the tests so they should be more stable. Will be pushing...
I think the `dataTest` failure is a race condition. I may have a fix, but, as is always the case with race conditions, testing is tricky and slow. :)
> Before moving out of draft state, please separate all the boilerplate around creating new API/xsd versions into a separate commit, followed by a commit with that introduces whatever is...
> This actually needs changes: > > 1. Makes a BasicOpenTelemetryTestCase fail with java.lang.IllegalStateException: Could not connect to Ryuk at localhost:34003 > > 2. needs a git squash 1. It...
> This actually needs changes: > > 1. Makes a BasicOpenTelemetryTestCase fail with java.lang.IllegalStateException: Could not connect to Ryuk at localhost:34003 > > 2. needs a git squash Squash done....
> @jasondlee Please change the target of this PR to 'main'. The mp-7-wip branch has been merged. @bstansberry Retargeted.