Jasonandjay

Results 41 comments of Jasonandjay

> TODO: > > * Figure out why deploy-doc is broken. > * Add more comments to various items in the library so that the docs are more fleshed out....

> Looks like `actions/configure-pages` is missing? logger report [Branch "doc" is not allowed to deploy to github-pages due to environment protection rules.] To allow the "doc" branch to deploy to...

Deploy doc task has updated, it will only take effect on master branch.

I think add version control is possible and necessary but with low priority. And flesh out documentation is how priority. I want to add description and examples to function、class、interface and...

For properties, we can add description like this, do you think its ok? ![proper](https://github.com/bitcoinjs/bitcoinjs-lib/assets/8192412/52862239-a668-4139-a6a4-77e45368080c)

Got it typedoc-plugin-bitcoinjs-runcase is a devDependencies, so it will not intrude into our program and help provide a run code environment when building documents. It will now be more efficient...

I did two things 1. ⏪ rollback: separate `typedoc-plugin-bitcoinjs-runcase` to another PR 2. Add key comments to the code to make the document look more complete.

Is there anything that needs to be optimized? Maybe we can push document construction to next step.

@elRaulito It's obvious that input1 doesn't exist, you should use addInput to add it If you have no further questions I will close this PR

Used for signing, since the output and address are using a tweaked key We must tweak the signer in the same way. You can refer to this: https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/test/integration/taproot.spec.ts#L51-L80