jsonapi-converter icon indicating copy to clipboard operation
jsonapi-converter copied to clipboard

allow alternate typenames and relationships

Open championswimmer opened this issue 5 years ago • 4 comments

This is to handle the case, where some server side serialization libraries might mixup singular and plural type names.

An example are these two nodejs libraries

https://www.npmjs.com/package/jsonapi-serializer - produces plurals https://www.npmjs.com/package/json-api-serializer - produces singulars

We can now support multiple types

@Type({"comments", "comment"})
public class Comment {
	@Id
	private String id;
	private String body;
	// ...
}

Signed-off-by: Arnav Gupta [email protected]

championswimmer avatar Jan 04 '20 22:01 championswimmer

@aggarwalpulkit596

championswimmer avatar Jan 04 '20 22:01 championswimmer

Hey @jasminb could you take a look at this please :)

Thanks

championswimmer avatar Jan 11 '20 12:01 championswimmer

@championswimmer This looks like a useful improvements, however instead of changing the Type annotation to an array and breaking things for all of the users, I would rather add another attribute to the annotation, eg. alternativeNames which could than be used by people who need it and all existing users don't need to change anything.

jasminb avatar Mar 04 '21 14:03 jasminb

@championswimmer This looks like a useful improvements, however instead of changing the Type annotation to an array and breaking things for all of the users, I would rather add another attribute to the annotation, eg. alternativeNames which could than be used by people who need it and all existing users don't need to change anything.

Well, ok that makes a lot more sense !

championswimmer avatar Mar 08 '21 22:03 championswimmer