tau Make parameters and variables constant when they are not mutated

Make parameters and variables constant when they are not mutated

Open tomasz-lisowski opened this issue 2 years ago • 2 comments

Jun 06 '22 14:06 tomasz-lisowski

Hey, can you please merge this?

Oct 24 '22 20:10 tomasz-lisowski

Please address my review changes from June.

Oct 25 '22 06:10 jasmcaus

@jasmcaus I don't see any code reviews from you on this pull request? What are you referring to?

Oct 25 '22 13:10 tomasz-lisowski

Strange. Just made some updates. LMK if you can see those.

Oct 25 '22 13:10 jasmcaus

I still don't see it. Are you sure you are submitting the code review? (big green "submit review" button :>)

Oct 25 '22 14:10 tomasz-lisowski

Yes. Strange why it isn't visible to you.

I'll add below what I'd added:

What's the difference between const char*..., char* const... and const char* const...? -- in tauShouldDecomposeMacro (tau.h:435)
Why the const* const? -- in tauCmdLineRead (tau.h:1019)

Oct 28 '22 09:10 jasmcaus

Sorry about that. Please see above reply.

Oct 28 '22 09:10 jasmcaus