Mainak Jas

Results 98 issues of Mainak Jas

### Discussed in https://github.com/jonescompneurolab/hnn-core/discussions/528 Originally posted by **chenghuzi** August 2, 2022 To write tutorials for the new GUI, it seems we need to consider comparing model output and recorded data....

hnn-gui-integration

The [plot_dipole](https://jonescompneurolab.github.io/hnn-core/stable/generated/hnn_core.viz.plot_dipole.html#hnn_core.viz.plot_dipole) function does not check the type of object. This leads to errors such as [reported here](https://github.com/jonescompneurolab/hnn-core/discussions/505#discussioncomment-3171051) by @wagdy88 Easy fix for a new contributor

good first issue

Currently `plot_morphology` is a method of `Cell`. However, for LFP plotting it is useful to have it as a method of `Network`. The current code would be refactored into a...

There is inconsistency in naming of parameters within HNN. Sometimes the name `L5_pyramidal` and other times it's called `L5Pyr`. This makes it hard to refactor some parts of the code....

maint

This was raised during a discussion with the NSG folks. It might be worth visiting at some point. The argument is that it will allow easier debugging. As long as...

maint

@ntolley mentioned [here](https://github.com/jonescompneurolab/hnn-core/pull/446#discussion_r809823548) that we don't have a way to save network objects. Since this is also a GSoC issue, I decided to make a quick prototype with hdf5: ```py...

IO

It looks we have two copies of the same function: drive_event_times _drive_cell_event_times we should remove one of them and update the tests to use only one function

good first issue

[sscce.org](http://sscce.org/) would be useful to develop some guidelines for this to avoid having to dig through hundreds of lines of code

docs

We saw this issue in autoreject and now MNE. Probably will affect `hnn-core`. We should port the solutions from there :)

maint

If we divide the histogram counts by the bin width, we can get instantaneous firing rate: https://jonescompneurolab.github.io/hnn-core/stable/generated/hnn_core.viz.plot_spikes_hist.html#hnn_core.viz.plot_spikes_hist To me it seems that would be more interpretable, e.g., if there is...

good first issue