Mainak Jas
Mainak Jas
can you share what the example outputs in the PR description?
whatever happened to this PR ? Was this close to merge? Is this something this year's GSoC student can work on?
@carolinafernandezp you seem to have rebase conflicts ... might be easiest to create a new branch from latest master, cherry pick your commits on to that branch, rename that branch...
The build is failing because of the GUI example ... @gtdang @kmilo9999 how best to address this? maybe we could separate the GUI examples into a separate build using Github...
How do we guarantee that the examples will run as expected for the user? unit tests?
alright, go for it ... please remove it so we can move ahead with @carolinafernandezp 's PR
Also we should use: https://matplotlib.org/3.1.1/api/_as_gen/matplotlib.pyplot.eventplot.html instead of `scatter` as mentioned by @ntolley
it's related to this function: https://jonescompneurolab.github.io/hnn-core/stable/generated/hnn_core.CellResponse.html#hnn_core.CellResponse.plot_spikes_raster when some cells do not spike, this plot omits those cell types. Instead, we want to always plot every cell type.
Should the color for prox and dist be different?
is the idea to have the 3 x 1 layout only the first plot after simulation? Subsequent plots will plot the proximal and distal together? Or would it make sense...