Jason Juang

Results 47 comments of Jason Juang

Can you enclose your code with triple "`"? It will be easier for us to read that way.

Here are a few more warnings on Windows: 1. https://github.com/CGAL/cgal/blob/daf70dbcf6d400cbece30ae173e3e951e48aed0a/Triangulation_2/include/CGAL/Constrained_triangulation_2.h#L1021 ``` warning C4702: unreachable code ``` Can we simply remove line 1021? 2. https://github.com/CGAL/cgal/blob/1082f223db46829c6bcfc0e0f338593275453a38/Polygon_mesh_processing/include/CGAL/Polyhedral_envelope.h#L758 and https://github.com/CGAL/cgal/blob/1082f223db46829c6bcfc0e0f338593275453a38/Polygon_mesh_processing/include/CGAL/Polyhedral_envelope.h#L906 ``` warning C4701: potentially...

Another warning in Visual Studio: https://github.com/CGAL/cgal/blob/master/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/remesh_impl.h#L935 ``` warning C4701: potentially uninitialized local variable 'deviation_post' used ``` Not initializing `deviation_post` in line 924 looks like it could cause undesired behavior. https://github.com/CGAL/cgal/blob/master/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/internal/Isotropic_remeshing/remesh_impl.h#L924

@lrineau here are the steps to reproduce it on Visual Studio 2019, Windows 10 ```shell vcpkg install cgal ``` CMakeLists.txt ```cmake set(CMAKE_TOOLCHAIN_FILE $ENV{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake) cmake_minimum_required(VERSION 3.20) project(example) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4 /WX")...

I just ran into the same problem and can be reproduced with the minimal example below: ``` ./vcpkg install pcl ``` CMakeLists.txt ``` set(CMAKE_TOOLCHAIN_FILE $ENV{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake) cmake_minimum_required(VERSION 3.20) project(example) find_package(PCL) add_executable(${PROJECT_NAME}...

> Hi @valvador92 glad to know someone is experiencing the same issue as me! > > I still could not solve the problem with Azure Kinect, but I have tried...

@amonnphillip thanks for sharing your experience and I will give that a try. Did you only re-calibrate the intrinsics of the color camera? Did you redo the intrinsics for the...

@amonnphillip I re-calibrate the intrinsics of the color camera but not the depth camera, and to my great surprise, it actually produces better alignment results than the one Azure Kinect...

After a ton of experiments, I believe this is not a calibration problem. It's a depth accuracy problem instead, and I believe the accuracy of the depth is highly affected...