activeuuid
activeuuid copied to clipboard
Rails5 Upgrade
Piggy backs off @inbeom's PR - fixes the test failures ( I think) and also does some refactoring to remove final deprecations from alias_method_chain
calls
I'd love to be able to merge this. Could you get the tests passing?
@jashmenn I think we'd better to merge my fork first, as this PR is based on that and all tests pass on it. You can take a look on https://github.com/inbeom/activeuuid.
Things changed:
- Dropped Ruby 2.0, Rails 3.x support.
- Updated JRuby version.
- Removed rbx environment from Travis manifest as Travis is far behind on updating it. (Confirmed tests passing on head of rbx)
May I open another PR?
Please merge the fork by inbeom. We've been using the rails5 fix in production for months.
Where has this been left?
@aren55555 You might want to try my fork. It passes the tests with Rails 5 environment.
@inbeom Without looking at all the commits; what is the difference between @jlsookiki's fork (aka this PR) and your fork?
How can I help to get this merged? What tests are failing? Where can I lend a hand?
If we can get the tests passing I'm happy to merge!
@jashmenn #85, what this one is based on, passes tests on the all environments but the obsolete ones. Can you consider merging it first? I think now almost no one expects gems to pass their tests on Ruby 2.0, RBX, JRuby while maintaining compatibility with the most recent versions of Ruby. Plus, Travis lacks support of recent versions of RBX and JRuby.
There are some more commits pushed to my fork regarding the narrowing down of supported environments, making its status green.
@jlsookiki and @inbeom I've added you as collaborators, feel free to merge when you believe this is ready
@jashmenn Thanks. I will catch up some open issues and prepare to put my hands on the maintenance of this gem.
@inbeom @jlsookiki do you still plan to merge these PRs?