activeuuid icon indicating copy to clipboard operation
activeuuid copied to clipboard

Rails5 Upgrade

Open jlsookiki opened this issue 8 years ago • 11 comments

Piggy backs off @inbeom's PR - fixes the test failures ( I think) and also does some refactoring to remove final deprecations from alias_method_chain calls

jlsookiki avatar Jan 13 '17 18:01 jlsookiki

I'd love to be able to merge this. Could you get the tests passing?

jashmenn avatar Jan 19 '17 15:01 jashmenn

@jashmenn I think we'd better to merge my fork first, as this PR is based on that and all tests pass on it. You can take a look on https://github.com/inbeom/activeuuid.

Things changed:

  • Dropped Ruby 2.0, Rails 3.x support.
  • Updated JRuby version.
  • Removed rbx environment from Travis manifest as Travis is far behind on updating it. (Confirmed tests passing on head of rbx)

May I open another PR?

inbeom avatar Jan 20 '17 01:01 inbeom

Please merge the fork by inbeom. We've been using the rails5 fix in production for months.

geori avatar Mar 20 '17 16:03 geori

Where has this been left?

aren55555 avatar Jun 08 '17 23:06 aren55555

@aren55555 You might want to try my fork. It passes the tests with Rails 5 environment.

inbeom avatar Jun 09 '17 01:06 inbeom

@inbeom Without looking at all the commits; what is the difference between @jlsookiki's fork (aka this PR) and your fork?

How can I help to get this merged? What tests are failing? Where can I lend a hand?

aren55555 avatar Jun 09 '17 21:06 aren55555

If we can get the tests passing I'm happy to merge!

jashmenn avatar Jun 09 '17 22:06 jashmenn

@jashmenn #85, what this one is based on, passes tests on the all environments but the obsolete ones. Can you consider merging it first? I think now almost no one expects gems to pass their tests on Ruby 2.0, RBX, JRuby while maintaining compatibility with the most recent versions of Ruby. Plus, Travis lacks support of recent versions of RBX and JRuby.

There are some more commits pushed to my fork regarding the narrowing down of supported environments, making its status green.

inbeom avatar Jun 14 '17 02:06 inbeom

@jlsookiki and @inbeom I've added you as collaborators, feel free to merge when you believe this is ready

jashmenn avatar Jun 22 '17 19:06 jashmenn

@jashmenn Thanks. I will catch up some open issues and prepare to put my hands on the maintenance of this gem.

inbeom avatar Jun 23 '17 01:06 inbeom

@inbeom @jlsookiki do you still plan to merge these PRs?

atyndall avatar Oct 31 '18 22:10 atyndall