docco icon indicating copy to clipboard operation
docco copied to clipboard

Fix broken templates

Open CrossEye opened this issue 1 year ago • 1 comments

Fixes #429 :

The problems is that

      if options.template
        unless options.css

should really be

      if config.template
        unless config.css

options is the whole Commander object. config is the combination of options.opts() and a default object.

CrossEye avatar Sep 25 '24 02:09 CrossEye

@jashkenas please merge and release. I will email you if you do not see this within a week.

jgonggrijp avatar Sep 25 '24 09:09 jgonggrijp

Any chance this can get reviewed soon?

CrossEye avatar Dec 31 '24 04:12 CrossEye

Pity, looks like this project is unmaintained. Anyone feel like forking and becoming maintainer?

egasimus avatar Jan 06 '25 11:01 egasimus

Hold on, I'm already in touch with @jashkenas because of Underscore and Backbone (of which I took over maintenance). We should be able to keep maintenance within the original repository.

jgonggrijp avatar Jan 07 '25 10:01 jgonggrijp

Any updates, @jgonggrijp, @jashkenas?

CrossEye avatar Mar 18 '25 14:03 CrossEye

I emailed @jashkenas twice but didn't hear back. The last one was a while ago, I'll try again.

jgonggrijp avatar Mar 18 '25 17:03 jgonggrijp

Very sorry about this — I missed Julian’s emails. I'll give him the deploy keys to Docco as well...

jashkenas avatar Mar 18 '25 18:03 jashkenas

Thanks for the swift response, @jashkenas!

I hereby confirm I have push access here on GitHub and the access rights to publish to NPM. Everyone, please submit pull requests and feel free to @mention me if you think a stale PR should be looked at again.

I will issue an update to NPM somewhere in the next week or so.

jgonggrijp avatar Mar 18 '25 19:03 jgonggrijp

Thank you both!!

CrossEye avatar Mar 19 '25 17:03 CrossEye

Published as version 0.9.2!

jgonggrijp avatar Mar 27 '25 19:03 jgonggrijp