docco icon indicating copy to clipboard operation
docco copied to clipboard

Published 20 hours ago • verified publisher icon jashkenas

LESS support broken, please revert patch

Open penx opened this issue 9 years ago • 4 comments

Please revert https://github.com/jashkenas/docco/pull/251 as it has broken LESS support added in https://github.com/jashkenas/docco/pull/136

As far as I can tell, the 'typo' mentioned in https://github.com/jashkenas/docco/pull/251 is not a typo. Hightlight.js does not support LESS, so the SCSS parser is used, as mentioned in https://github.com/jashkenas/docco/pull/136.

penx avatar Jul 14 '14 10:07 penx

How can less be wrong that is should parse with Less? sccs is different from less.

kevinsimper avatar Jul 29 '14 19:07 kevinsimper

They are similar enough that the SCSS parser can be used for docco (at least, that was the intention of #136). If there was an LESS parser for Highlight.js, it could be used. There isn't one, so #251 breaks LESS support.

penx avatar Sep 09 '14 13:09 penx

@penx if you make a PR to correct it, I'll merge. If you wanted to be really awesome though, you could push this to get merged instead: https://github.com/isagalaev/highlight.js/pull/558. Then everyone wins.

keithamus avatar Sep 09 '14 14:09 keithamus

isagalaev/highlight.js#558 was actually merged!

mercmobily avatar Dec 19 '17 07:12 mercmobily