Jeremy Ashkenas comments

Results 108 comments of


                                            Jeremy Ashkenas

V2: Model events during "remove" do not trigger on Col

That makes perfect sense. You really don't think this should be merged?

Rethink parsing (Collection#set doesn't intelligently merge unparsed models)

Perhaps. I'm not sure if this is something that is intended to be handled by `modelId` these days, or by `parse`? Anyone?

Rethink parsing (Collection#set doesn't intelligently merge unparsed models)

Oh, right, so ids need to be parsed out at the collection level then...

Rethink parsing (Collection#set doesn't intelligently merge unparsed models)

For a `v2`, we should rethink parsing entirely. The way it's currently implemented is quite half-assed, as a result of it never having been used in DocumentCloud originally (IMHO). I'd...

Backbone.history.navigate( '/' ) strips slash

Is there a PR to address this?

Backbone.history.navigate( '/' ) strips slash

> Would a PR on that be welcome? It's 2 lines of code and then tests. Happy to take a look, if you want to open the PR...

#3941 return decoded hash in getHash()

> This seems to break browsers 'back' navigation button. However, it does fix the above stated problem. Uh.

Return a rejected promise instead of false on invalid model save

Yes -- I'm fairly far towards leaning towards a "no go" on this ... but I haven't sat down and thought about it as much as I'd like to just...

Return a rejected promise instead of false on invalid model save

Closing this particular PR. I'd still be happy to look at and discuss a more holistic approach to pervasive promises, in concert with a version bump ... but it looks...

Return a rejected promise instead of false on invalid model save

Opening for more discussion ... but we'd still need a real patch+proposal.